refactor: move fee fields resolution into validation methods#3461
Merged
refactor: move fee fields resolution into validation methods#3461
Conversation
klkvr
changed the title
0xrusowsky
reviewed
Apr 7, 2026
crates/revm/src/handler.rs
Outdated
Contributor
There was a problem hiding this comment.
nit: the check now happens in validate_against_state_and_deduct_caller
0xrusowsky
approved these changes
Apr 7, 2026
Contributor
0xrusowsky
left a comment
0xrusowsky
left a comment
There was a problem hiding this comment.
nice, this is a great simplification!
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
) Based on #3461 Changes `TempoTransactionValidator` to fully delegate validation of transactions to `TempoEvm`. This removes a lot of tests (mostly the ones that were covering `validate_against_keychain`). My assumption is that validator would now fully inherit EVM test coverage and if some scenarios are not covered there we should just migrate the tests --------- Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_fee_fieldsis a bit weird because it's technically performing a stateful validation of the fee token before any stateless validations of the transaction happenedrevm defines clear separation of stateless and stateful checks (
validate_envvsvalidate_against_state_and_deduct_caller) and this PR changes fee token/payer resolution to follow it as well